fix: compatibility with vuex4: no changing of store data outside of mutations #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -406,7 +406,11 @@ function HalJsonVuex (store: Store<Record<string, State>>, axios: AxiosInstance, | |||
| function setLoadPromiseOnStore (uri: string, loadStoreData: Promise<StoreData> | null = null) { | |||
| const promise: SerializablePromise<StoreData> = loadStoreData || Promise.resolve(store.state[opts.apiName][uri]) | |||
| promise.toJSON = () => '{}' // avoid warning in Nuxt when serializing the complete Vuex store ("Cannot stringify arbitrary non-POJOs Promise") | |||
| store.state[opts.apiName][uri]._meta.load = promise | |||
|
|
|||
| store.commit('setLoadPromise', { | |||
There was a problem hiding this comment.
Have you read the comment on line 399? I think I had to do it thisway, otherwise I would run into problems... Change LGTM, but I'm unsure because of that comment
There was a problem hiding this comment.
From the structure and the comment, i think this should probably only be done once?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise this will throw an console error in vuex.
Haven't seen any negative side effects so far, but we should observe carefully.
+ running linter